Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2379: [Format] Update changelog for 2.10.0 #219

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

wgtmac
Copy link
Member

@wgtmac wgtmac commented Nov 15, 2023

Make sure you have checked all steps below.

Jira

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

@wgtmac
Copy link
Member Author

wgtmac commented Nov 15, 2023

@gszadovszky @Fokko @shangxinli

Could you please take a look?

Copy link
Member

@mapleFU mapleFU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking this up @wgtmac 👍

Copy link
Contributor

@gszadovszky gszadovszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on a release, @wgtmac!

Some comments:

  • nit: it would be nice to have the jiras sorted
  • PARQUET-2222 is listed twice
  • I guess, you've used the release query in jira. That's fine but we also should match jira with the actual changesets got in first and update the jiras accordingly. Because of that we are missing some jiras in the list (e.g. PARQUET-2005, PARQUET-2019)

@wgtmac
Copy link
Member Author

wgtmac commented Nov 15, 2023

Thanks for the suggestion! @gszadovszky

PARQUET-2222 has two different commits associated with it. Let me consolidate them.

I just scanned all commits since last release and dropped two kinds of commits:

  • Commits without an JIRA issue.
  • Commits that are created by GH dependabot.

Should I open a JIRA for commits that do not open a JIRA? But unfortunately the commit message can no longer change.

@gszadovszky
Copy link
Contributor

@wgtmac,
When I am doing a release, I usually start with the list commits as you've done. Then update the jira accordingly (usually we miss to set the proper target release). After it is done I use the jira release page, this time it is https://issues.apache.org/jira/projects/PARQUET/versions/12350092.
At this time it would already contain all the jiras already in the release and also the ones someone wanted to do for this release. The latter ones should be investigated whether they really got in or not. If not, should we wait for them. At the end we should have only the jiras in under the target version which are really made into the release. Then create the changelog. (At this point the changelog is redundant, but we usually create it anyway.) There is a somewhat useful tool linked at https://parquet.apache.org/docs/contribution-guidelines/releasing/#release-process to convert the jira query result to the required md format.

I don't think we need jiras for the changes got in without them. Though, it might worth listing the updates in the changelog. Maybe under "Tasks"?

@wgtmac
Copy link
Member Author

wgtmac commented Nov 15, 2023

I have updated the status of all JIRAs belong to the release. The changelog is updated as well. Please take a look again. Thanks! @gszadovszky

@wgtmac
Copy link
Member Author

wgtmac commented Nov 16, 2023

Thanks @mapleFU @Fokko @gszadovszky! I'll merge this.

@wgtmac wgtmac merged commit da09d82 into apache:master Nov 16, 2023
3 checks passed
@wgtmac
Copy link
Member Author

wgtmac commented Nov 17, 2023

Hi @gszadovszky @shangxinli @ggershinsky, could you help the vote below? Thanks in advance!

https://lists.apache.org/thread/fdf1zz0f3xzz5zpvo6c811xjswhm1zy6

@shangxinli
Copy link

shangxinli commented Nov 17, 2023 via email

@wgtmac
Copy link
Member Author

wgtmac commented Nov 20, 2023

@Fokko Could you invite PMCs you know to help the vote? Thanks!

@gszadovszky
Copy link
Contributor

Thanks @wgtmac for the heads up! Voted.

@wgtmac
Copy link
Member Author

wgtmac commented Nov 20, 2023

Thanks @gszadovszky!

Could you help me on the step 3 of the link below? It seems that I don't have the permission.
https://parquet.apache.org/docs/contribution-guidelines/releasing/#3-copy-the-release-artifacts-in-svn-into-releases

mkdir parquet
cd parquet
svn co https://dist.apache.org/repos/dist/dev/parquet candidates
svn co https://dist.apache.org/repos/dist/release/parquet releases

cp -r candidates/apache-parquet-format-2.10.0-rc0/ releases/apache-parquet-format-2.10.0

cd releases
svn add apache-parquet-format-2.10.0
svn ci -m "Parquet Format: Add release 2.10.0"

@gszadovszky
Copy link
Contributor

@wgtmac, I've done the steps you've listed. downloads.apache.org and mirrors will probably need some to time to get in sync.

@wgtmac
Copy link
Member Author

wgtmac commented Nov 20, 2023

Thank you very much! @gszadovszky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants