-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PARQUET-2379: [Format] Update changelog for 2.10.0 #219
Conversation
@gszadovszky @Fokko @shangxinli Could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for picking this up @wgtmac 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working on a release, @wgtmac!
Some comments:
- nit: it would be nice to have the jiras sorted
- PARQUET-2222 is listed twice
- I guess, you've used the release query in jira. That's fine but we also should match jira with the actual changesets got in first and update the jiras accordingly. Because of that we are missing some jiras in the list (e.g. PARQUET-2005, PARQUET-2019)
Thanks for the suggestion! @gszadovszky PARQUET-2222 has two different commits associated with it. Let me consolidate them. I just scanned all commits since last release and dropped two kinds of commits:
Should I open a JIRA for commits that do not open a JIRA? But unfortunately the commit message can no longer change. |
@wgtmac, I don't think we need jiras for the changes got in without them. Though, it might worth listing the updates in the changelog. Maybe under "Tasks"? |
I have updated the status of all JIRAs belong to the release. The changelog is updated as well. Please take a look again. Thanks! @gszadovszky |
Thanks @mapleFU @Fokko @gszadovszky! I'll merge this. |
Hi @gszadovszky @shangxinli @ggershinsky, could you help the vote below? Thanks in advance! https://lists.apache.org/thread/fdf1zz0f3xzz5zpvo6c811xjswhm1zy6 |
I just voted
…On Fri, Nov 17, 2023 at 7:03 AM Gang Wu ***@***.***> wrote:
Hi @gszadovszky <https://github.com/gszadovszky> @shangxinli
<https://github.com/shangxinli> @ggershinsky
<https://github.com/ggershinsky>, could you help the vote below? Thanks
in advance!
https://lists.apache.org/thread/fdf1zz0f3xzz5zpvo6c811xjswhm1zy6
—
Reply to this email directly, view it on GitHub
<#219 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHPXKMLJSRV7OLSRIMNIV3DYE54ETAVCNFSM6AAAAAA7L6BY7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGU4DMNJXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Xinli Shang
|
@Fokko Could you invite PMCs you know to help the vote? Thanks! |
Thanks @wgtmac for the heads up! Voted. |
Thanks @gszadovszky! Could you help me on the step 3 of the link below? It seems that I don't have the permission.
|
@wgtmac, I've done the steps you've listed. downloads.apache.org and mirrors will probably need some to time to get in sync. |
Thank you very much! @gszadovszky |
Make sure you have checked all steps below.
Jira
Commits
Documentation