Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section of testing #442

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add section of testing #442

merged 1 commit into from
Jul 3, 2024

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jul 3, 2024

Make sure you have checked all steps below.

Jira

Closes #273

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Fokko

@emkornfield
Copy link
Contributor

LGTM. merging.

@emkornfield emkornfield merged commit ed66e87 into master Jul 3, 2024
6 checks passed
@Fokko Fokko deleted the fd-add-testing-section branch July 3, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a corpus of Parquet files that client implementations can use for validation
4 participants