Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimize error message format #447

Merged
merged 5 commits into from
Sep 24, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Sep 24, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

fix: #444

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@mlycore mlycore added pitr solutions of pitr type: refactor labels Sep 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2023

Codecov Report

Merging #447 (5dd5db7) into main (3604a24) will decrease coverage by 3.40%.
Report is 181 commits behind head on main.
The diff coverage is 23.16%.

@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   39.71%   36.32%   -3.40%     
==========================================
  Files          51       59       +8     
  Lines        6083     6615     +532     
==========================================
- Hits         2416     2403      -13     
- Misses       3448     3985     +537     
- Partials      219      227       +8     
Files Changed Coverage Δ
pitr/agent/internal/handler/diskspace.go 40.00% <0.00%> (ø)
pitr/agent/internal/handler/restore.go 0.00% <0.00%> (ø)
pitr/agent/internal/handler/show.go 0.00% <0.00%> (ø)
pitr/cli/internal/cmd/restore.go 58.33% <0.00%> (-0.99%) ⬇️
pitr/cli/internal/pkg/local-storage.go 40.65% <0.00%> (-2.09%) ⬇️
pitr/cli/internal/pkg/shardingsphere-proxy.go 15.51% <0.00%> (ø)
...tor/cmd/shardingsphere-operator/manager/manager.go 0.00% <0.00%> (ø)
...operator/pkg/controllers/auto_scaler_controller.go 0.00% <0.00%> (ø)
...phere-operator/pkg/controllers/chaos_controller.go 0.00% <0.00%> (ø)
...perator/pkg/controllers/compute_node_controller.go 0.00% <0.00%> (ø)
... and 22 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@zhaojinchao95 zhaojinchao95 merged commit 7bbc2be into apache:main Sep 24, 2023
8 checks passed
@mlycore mlycore deleted the err-handle branch September 24, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pitr solutions of pitr type: refactor
Projects
None yet
3 participants