Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable NNPACK build and fix error on Android SDK installaion #17337

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

mshr-h
Copy link
Contributor

@mshr-h mshr-h commented Sep 5, 2024

Fix #17070

@mshr-h mshr-h changed the title [CI][Bugfix] Disable NNPACK build on CI [CI] Disable NNPACK build on CI Sep 5, 2024
@mshr-h mshr-h closed this Sep 5, 2024
@mshr-h mshr-h reopened this Sep 5, 2024
@mshr-h mshr-h marked this pull request as ready for review September 5, 2024 15:37
@mshr-h
Copy link
Contributor Author

mshr-h commented Sep 10, 2024

@tqchen Thank you for your review. Please let me know if there's anything else that should be changed besides removing the NNPACK installation.

@yongwww
Copy link
Member

yongwww commented Sep 10, 2024

@tvm-bot rerun

@yongwww
Copy link
Member

yongwww commented Sep 10, 2024

we can find the nnpack related code under /contrib/nnpack/, and some operations like _conv2d_arm_cpu_winograd_nnpack, I guess we will need to gradually deprecate those in the future.

@tqchen
Copy link
Member

tqchen commented Sep 10, 2024

we can remove the related supporting code as well as long as they are legacy, especially given we ar emoving towards relax

@mshr-h
Copy link
Contributor Author

mshr-h commented Sep 12, 2024

Looking at the docker ci build log, it seems like the Android SDK installation is failing.
https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-docker/detail/PR-17337/3/pipeline

[2024-09-10T15:30:06.331Z] 14.60 Accept? (y/N): All SDK package licenses accepted
[2024-09-10T15:30:06.331Z] 14.60 done
[2024-09-10T15:30:06.331Z] 15.46 Warning: Failed to find package extras;m2repository;com;android;support;constraint;constraint-layout;1.0.2
[2024-09-10T15:30:06.331Z] ------
[2024-09-10T15:30:06.331Z] Dockerfile.ci_cpu:130
[2024-09-10T15:30:06.331Z] --------------------
[2024-09-10T15:30:06.331Z] 128 | # Android SDK
[2024-09-10T15:30:06.331Z] 129 | COPY install/ubuntu_install_androidsdk.sh /install/ubuntu_install_androidsdk.sh
[2024-09-10T15:30:06.331Z] 130 | >>> RUN bash /install/ubuntu_install_androidsdk.sh
[2024-09-10T15:30:06.331Z] 131 |
[2024-09-10T15:30:06.331Z] 132 | # PaddlePaddle deps
[2024-09-10T15:30:06.331Z] --------------------
[2024-09-10T15:30:06.331Z] ERROR: failed to solve: process "/bin/sh -c bash /install/ubuntu_install_androidsdk.sh" did not complete successfully: exit code: 1
[2024-09-10T15:30:06.331Z] ERROR: docker build failed.

@mshr-h mshr-h force-pushed the disable-nnpack-ci branch 4 times, most recently from 6cbce42 to ae093b0 Compare September 14, 2024 12:36
@mshr-h mshr-h changed the title [CI] Disable NNPACK build on CI [CI] Disable NNPACK build and fix error on Android SDK installaion Sep 16, 2024
@mshr-h mshr-h marked this pull request as draft September 16, 2024 13:25
@tqchen
Copy link
Member

tqchen commented Sep 16, 2024

We can disable/remove the android docker for now given most android SDK are used without docker atm

@mshr-h mshr-h marked this pull request as ready for review September 16, 2024 15:49
@tqchen tqchen merged commit d3900be into apache:main Sep 17, 2024
14 checks passed
@mshr-h mshr-h deleted the disable-nnpack-ci branch September 17, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ci_cpu docker image build fail
3 participants