feat: set project endpoint based on the region #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-11-12 16:13:03 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-11-12 16:13:02 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-11-12 16:15:22 CET |
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-11-12 16:15:30 CET |
src/lib/constants.ts
Outdated
Comment on lines
5
to
11
| export const REGION_FRA = 'fra'; | ||
| export const REGION_SYD = 'syd'; | ||
| export const REGION_NYC = 'nyc'; | ||
|
|
||
| export const SUBDOMAIN_FRA = 'fra.'; | ||
| export const SUBDOMAIN_SYD = 'syd.'; | ||
| export const SUBDOMAIN_NYC = 'nyc.'; |
There was a problem hiding this comment.
I dont think we need constants for that, its good enough to have them locally in the sdk.ts
Comment on lines
+44
to
+55
| const getSubdomain = (region?: string) => { | ||
| switch (region) { | ||
| case REGION_FRA: | ||
| return SUBDOMAIN_FRA; | ||
| case REGION_SYD: | ||
| return SUBDOMAIN_SYD; | ||
| case REGION_NYC: | ||
| return SUBDOMAIN_NYC; | ||
| default: | ||
| return ''; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const getSubdomain = (region?: string) => { | |
| switch (region) { | |
| case REGION_FRA: | |
| return SUBDOMAIN_FRA; | |
| case REGION_SYD: | |
| return SUBDOMAIN_SYD; | |
| case REGION_NYC: | |
| return SUBDOMAIN_NYC; | |
| default: | |
| return ''; | |
| } | |
| }; | |
| const getSubdomain = (region?: string) => { | |
| return region ? `${region}.` : ''; | |
| }; |
we should probably avoid hardcoding regions for this in the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)