fix: preserve morphs on some piped properties #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimava
commented
Oct 12, 2024
Comment on lines
201
to
207
|
|
||
| return ctx.$.node("morph", { | ||
| morphs, | ||
| in: from.in | ||
| in: from.inner.in as any | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
I used as any but maybe it should be typed better
ssalbdivad
approved these changes
Oct 12, 2024
| @@ -201,7 +201,7 @@ const _pipeMorphed = ( | |||
|
|
|||
| return ctx.$.node("morph", { | |||
| morphs, | |||
| in: from.in | |||
| in: from.inner.in as any | |||
There was a problem hiding this comment.
I would usually use as never in a case like this but I can update that later, it's pretty inconsequential.
There was a problem hiding this comment.
Please check the types anyway, there's a good chance it shouldn't need the case at all
ssalbdivad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.