Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need to inject Version manually #768

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove the need to inject Version manually #768

wants to merge 3 commits into from

Commits on Sep 23, 2024

  1. Simplify the building process for end users. 

    Use debug.ReadBuildInfo() to generate Version.

Before:
    $ CGO_ENABLED=0 go install ./cmd/goatcounter
    $ goatcounter version
    version=dev; go=go1.23.1; GOOS=linux; GOARCH=amd64; race=false; cgo=false

After:
    $ CGO_ENABLED=0 go install ./cmd/goatcounter
    $ goatcounter version
    version=535cf676f9a3_2024-09-23T18:24:51Z; go=go1.23.1; GOOS=linux; GOARCH=amd64; race=false; cgo=false

After, with a locally modified file:
    $ CGO_ENABLED=0 go install ./cmd/goatcounter
    $ goatcounter version
    version=8ab2fe057181_2024-09-23T18:49:30Z-dev; go=go1.23.1; GOOS=linux; GOARCH=amd64; race=false; cgo=false

Technically this variable should live inside cmd/goatcounter but that
would be a more significant refactoring.
    @maruel
    maruel committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    64bd72f View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Revert Version comment; also init when Version is empty

    @maruel
    maruel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    39887bd View commit details
    Browse the repository at this point in the history

  2. Revert Version comment spacing change

    @maruel
    maruel committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f93e058 View commit details
    Browse the repository at this point in the history