Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo Qodana upgrade #1337

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,35 +38,25 @@ jobs:
with:
fetch-depth: ${{ github.event.pull_request.commits }}

- name: Download AsciiDoc plugin for AsciiDoc checks
run: |
curl -L -o asciidoctor-intellij-plugin.zip https://github.com/asciidoctor/asciidoctor-intellij-plugin/releases/download/0.38.2/asciidoctor-intellij-plugin-0.38.2.zip
unzip asciidoctor-intellij-plugin.zip
- name: Get one more commit so Qodana we can identify the changes
if: github.event_name == 'pull_request'
run: git fetch --deepen=1

- name: Download Grazie plugin for grammar checks
# https://plugins.jetbrains.com/plugin/12175-grazie/versions
run: |
curl -L -o grazie.zip 'https://plugins.jetbrains.com/plugin/download?rel=true&updateId=257026'
unzip grazie.zip

- name: Download Grazie Professional plugin for grammar checks
# https://plugins.jetbrains.com/plugin/16136-grazie-professional/versions
run: |
curl -L -o grazie-pro.zip 'https://plugins.jetbrains.com/plugin/download?rel=true&updateId=260567'
unzip grazie-pro.zip

- name: Create empty folder to overwrite disabled plugin
run: |
mkdir empty

- name: Get one more commit so Qodana we can identify the changes
if: github.event_name == 'pull_request'
run: git fetch --deepen=1

- name: 'Qodana for Docs'
uses: JetBrains/[email protected]
with:
upload-result: true
pr-mode: false
# https://hub.docker.com/r/jetbrains/qodana-jvm-community/tags
# this disables the Gradle plugin to avoid the Gradle initialization and the dependency download
# as that is not necessary for the Grazie and AsciiDoc plugins to check spelling and links.
Expand All @@ -75,10 +65,7 @@ jobs:
args: >
--linter,jetbrains/qodana-jvm-community:2023.2,
--property=idea.suppressed.plugins.id=com.intellij.gradle,
-v,${{ github.workspace }}/grazie:/opt/idea/plugins/grazie,
-v,${{ github.workspace }}/empty:/opt/idea/plugins/gradle-java,
-v,${{ github.workspace }}/grazie-pro:/opt/idea/plugins/grazie-pro,
-v,${{ github.workspace }}/asciidoctor-intellij-plugin:/opt/idea/plugins/asciidoctor-intellij-plugin,
--baseline,doc/qodana-baseline.sarif.json

# https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github#example-workflow-that-runs-the-eslint-analysis-tool
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,5 @@ include::example$workflow-docs.yml[tags=!cleanup]
The following issues in the Qodana issue tracker are open.
Voting for them will make this integration simpler.

* https://youtrack.jetbrains.com/issue/QD-1291[QD-1291^]
Qodana easy plugin installation
* https://youtrack.jetbrains.com/issue/QD-1290[QD-1290^]
Add soft wrap to code preview

3 changes: 3 additions & 0 deletions qodana.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
version: 1.0
profile:
path: doc/asciidoc-inspection.xml
plugins:
# Order of plugin in the order which they depend on. AsciiDoc depends on Qodana pro, therefore add it after
- id: org.asciidoctor.intellij.asciidoc
exclude:
- name: All
paths:
Expand Down