Changes to the FITS-header Tutorial #559
Conversation
saimafsiddiqui
commented
May 29, 2022
•
saimafsiddiqui
commented
- Check the box to confirm that you are familiar with the contributing guidelines and/or indicate (check the box) that you are familiar with our contributing workflow.
- Confirm that any contributed tutorials contain a complete Introduction which includes an Author list, Learning Goals, Keywords, Companion Content (if applicable), and a Summary.
- Check the box to confirm that you are familiar with the Astropy community code of conduct and you agree to follow the CoC.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Hi 👋 @saimafsiddiqui and thanks for this pull request! It is good to have people taking a fresh look at these tutorials.
I have several suggestion below -- mostly very minor. FITS is a weird file format, in that it is strict in some ways (keywords can have no more than 8 characters) but very loose in others (images can be in any HDU), so I tried to note some cases where you will want to be a little less broad in how you talk about fits.
Thanks again for working on this!
| "id": "qkFwDQUCmv2Y" | ||
| }, | ||
| "source": [ | ||
| "Most of the time, the convenience functions are the easiest way to access the data. `fits.getdata()` reads only the data from a FITS file, but with the `header=True` keyword argument will also read the header. " |
There was a problem hiding this comment.
I'm not sure I agree that this is the easiest -- if you just need the header or data alone and don't need to modify the file, then maybe it is more convenient. If you want to change the file, though, I think fits.open is probably preferable.
There was a problem hiding this comment.
Thank you! I'll change how I wrote that and add a little more about the functions for clarity.
fixed quotations Co-authored-by: Matt Craig <[email protected]>
Co-authored-by: Matt Craig <[email protected]>
Co-authored-by: Matt Craig <[email protected]>
Co-authored-by: Matt Craig <[email protected]>
Co-authored-by: Matt Craig <[email protected]>
Co-authored-by: Matt Craig <[email protected]>
Co-authored-by: Matt Craig <[email protected]>
for more information, see https://pre-commit.ci
|
@mwcraig Can you check that your changes were implemented properly? If not, I'll contact Saima so we can upload her updates. |
