Skip to content

Commit

Permalink
Remove the internal tag from Core classes used in other packages (#1486)
Browse files Browse the repository at this point in the history
  • Loading branch information
stof authored Jul 1, 2023
1 parent 57ff962 commit 6ca369f
Show file tree
Hide file tree
Showing 16 changed files with 7 additions and 45 deletions.
3 changes: 0 additions & 3 deletions src/Core/src/AwsError/AwsError.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

namespace AsyncAws\Core\AwsError;

/**
* @internal
*/
final class AwsError
{
/**
Expand Down
3 changes: 0 additions & 3 deletions src/Core/src/AwsError/AwsErrorFactoryFromResponseTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@

use Symfony\Contracts\HttpClient\ResponseInterface;

/**
* @internal
*/
trait AwsErrorFactoryFromResponseTrait
{
public function createFromResponse(ResponseInterface $response): AwsError
Expand Down
3 changes: 0 additions & 3 deletions src/Core/src/AwsError/AwsErrorFactoryInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@

use Symfony\Contracts\HttpClient\ResponseInterface;

/**
* @internal
*/
interface AwsErrorFactoryInterface
{
public function createFromResponse(ResponseInterface $response): AwsError;
Expand Down
5 changes: 1 addition & 4 deletions src/Core/src/AwsError/JsonRestAwsErrorFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
use AsyncAws\Core\Exception\UnexpectedValue;
use AsyncAws\Core\Exception\UnparsableResponse;

/**
* @internal
*/
class JsonRestAwsErrorFactory implements AwsErrorFactoryInterface
final class JsonRestAwsErrorFactory implements AwsErrorFactoryInterface
{
use AwsErrorFactoryFromResponseTrait;

Expand Down
5 changes: 1 addition & 4 deletions src/Core/src/AwsError/JsonRpcAwsErrorFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@
use AsyncAws\Core\Exception\UnexpectedValue;
use AsyncAws\Core\Exception\UnparsableResponse;

/**
* @internal
*/
class JsonRpcAwsErrorFactory implements AwsErrorFactoryInterface
final class JsonRpcAwsErrorFactory implements AwsErrorFactoryInterface
{
use AwsErrorFactoryFromResponseTrait;

Expand Down
5 changes: 1 addition & 4 deletions src/Core/src/AwsError/XmlAwsErrorFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@
use AsyncAws\Core\Exception\UnexpectedValue;
use AsyncAws\Core\Exception\UnparsableResponse;

/**
* @internal
*/
class XmlAwsErrorFactory implements AwsErrorFactoryInterface
final class XmlAwsErrorFactory implements AwsErrorFactoryInterface
{
use AwsErrorFactoryFromResponseTrait;

Expand Down
2 changes: 0 additions & 2 deletions src/Core/src/Input.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
* Representation of a AWS Request.
*
* @author Jérémy Derussé <[email protected]>
*
* @internal
*/
abstract class Input
{
Expand Down
4 changes: 1 addition & 3 deletions src/Core/src/Request.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@
* Representation of an HTTP Request.
*
* @author Jérémy Derussé <[email protected]>
*
* @internal
*/
class Request
final class Request
{
/**
* @var string
Expand Down
4 changes: 1 addition & 3 deletions src/Core/src/RequestContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@
* Contains contextual information alongside a request.
*
* @author Jérémy Derussé <[email protected]>
*
* @internal
*/
class RequestContext
final class RequestContext
{
public const AVAILABLE_OPTIONS = [
'region' => true,
Expand Down
4 changes: 1 addition & 3 deletions src/Core/src/Response.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,8 @@
* The response provides a facade to manipulate HttpResponses.
*
* @author Jérémy Derussé <[email protected]>
*
* @internal
*/
class Response
final class Response
{
/**
* @var ResponseInterface
Expand Down
4 changes: 1 addition & 3 deletions src/Core/src/Signer/SigningContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,9 @@
use AsyncAws\Core\Request;

/**
* @internal
*
* @author Jérémy Derussé <[email protected]>
*/
class SigningContext
final class SigningContext
{
/**
* @var Request
Expand Down
2 changes: 0 additions & 2 deletions src/Core/src/Stream/FixedSizeStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
* A Stream decorator that return Chunk with the same exact size.
*
* @author Jérémy Derussé <[email protected]>
*
* @internal
*/
final class FixedSizeStream implements RequestStream
{
Expand Down
2 changes: 0 additions & 2 deletions src/Core/src/Stream/IterableStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
* Convert an iterator into a Stream.
*
* @author Jérémy Derussé <[email protected]>
*
* @internal
*/
final class IterableStream implements ReadOnceResultStream, RequestStream
{
Expand Down
2 changes: 0 additions & 2 deletions src/Core/src/Stream/ReadOnceResultStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@

/**
* Marker for ResultStream that can be read only once.
*
* @internal
*/
interface ReadOnceResultStream
{
Expand Down
2 changes: 0 additions & 2 deletions src/Core/src/Stream/RequestStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
*
* @author Jérémy Derussé <[email protected]>
*
* @internal
*
* @extends \IteratorAggregate<string>
*/
interface RequestStream extends \IteratorAggregate
Expand Down
2 changes: 0 additions & 2 deletions src/Core/src/Stream/RewindableStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
* - hash
*
* @author Jérémy Derussé <[email protected]>
*
* @internal
*/
final class RewindableStream implements RequestStream
{
Expand Down

0 comments on commit 6ca369f

Please sign in to comment.