Skip to content

Commit

Permalink
Upgrade psalm (#1462)
Browse files Browse the repository at this point in the history
* Upgrade psalm

* Disable the ArgumentTypeCoercion rule of Psalm for now

This gets reported for any Result object populating enum fields due to
not validating the enum value in this generated code. This may be
re-enabled in the future once the generated code passes it.

* Use composer to install the phar

* Regenerate the psalm baseline

* Add explicit configuration for settings that will change default

This avoids getting warnings when running Psalm.

* Fix potential undefined array offset

* Disable the PropertyTypeCoercion rule of Psalm for now
  • Loading branch information
stof authored Jun 26, 2023
1 parent ae0d147 commit a16f3eb
Show file tree
Hide file tree
Showing 5 changed files with 453 additions and 185 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,4 @@ jobs:
composer update --no-interaction --prefer-dist --optimize-autoloader
- name: Psalm
uses: docker://vimeo/psalm-github-actions:5.1.0
env:
REQUIRE_DEV: "true"
with:
args: --no-progress --show-info=false --stats
run: vendor/bin/psalm.phar --no-progress --show-info=false --stats
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"nette/utils": "^3.0",
"nyholm/symfony-bundle-test": "^2.0",
"phpstan/phpstan": "1.10.21",
"psalm/phar": "5.11.0",
"psr/cache": "^1.0 || ^2.0 || ^3.0",
"swaggest/json-diff": "^3.7",
"symfony/cache": "^4.4 || ^5.0 || ^6.0 || ^7.0",
Expand Down
Loading

0 comments on commit a16f3eb

Please sign in to comment.