Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature for callable types #1463

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Add signature for callable types #1463

merged 3 commits into from
Jun 23, 2023

Conversation

stof
Copy link
Member

@stof stof commented Jun 23, 2023

This allow static analyser tools to report invalid callables being provided.

The only callable signature we have in the project is related to RequestStream for streaming shape members.

phpstan is updated to enforce providing such types for the future.

@stof stof merged commit 69c7bff into async-aws:master Jun 23, 2023
@stof stof deleted the callable_type branch June 23, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants