Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symfony Bundle] Fix the usage of a deprecated class #1717

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

javiereguiluz
Copy link
Contributor

Fixes this issue spotted while updating some app to Symfony 7.1:

The "Symfony\Component\HttpKernel\DependencyInjection\Extension" class is considered
internal since Symfony 7.1, to be deprecated in 8.1;
use Symfony\Component\DependencyInjection\Extension\Extension instead.
It may change without further notice. You should not use it from 
"AsyncAws\Symfony\Bundle\DependencyInjection\AsyncAwsExtension".

@jderusse
Copy link
Member

Hello, tests are failing. Could you please add an entry in the Symfony/Bundle changelog file?

@javiereguiluz
Copy link
Contributor Author

javiereguiluz commented May 31, 2024

Do we really need an entry in the changelog? The new Symfony class is available since Symfony 5.4, so this change should be completely transparent to end users 🤔 In any case, I added the entry. Thanks.

@jderusse
Copy link
Member

Do we really need an entry in the changelog? The new Symfony class is available since Symfony 5.4, so this change should be completely transparent to end users 🤔 In any case, I added the entry. Thanks.

It's required, to automate the releasing of components. I have a script that use the changelog to define the next version (patch / minor)

@jderusse jderusse merged commit b53ae32 into async-aws:master Jun 3, 2024
15 of 16 checks passed
@jderusse
Copy link
Member

jderusse commented Jun 3, 2024

Thank you @javiereguiluz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants