Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve dependencies with phpunit version installed by simple-phpunit #1730

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Jun 18, 2024

SimplePhpunit downloads the version 9.6 of PhpUnit, but some dependencies might requires another version of PHPUnit.
As a result, we have 2 differents version of the library installed in the vendors and the autoloader might load the classes in a different order.

Leading to errors like:

PHP Fatal error: Declaration of PHPUnit\Framework\TestSuite::run(): void must be compatible with PHPUnit\Framework\Test::run(?PHPUnit\Framework\TestResult $result = null): PHPUnit\Framework\TestResult in /home/runner/work/aws/aws/vendor/phpunit/phpunit/src/Framework/TestSuite.php on line 328

@jderusse jderusse merged commit 05d3e01 into async-aws:master Jun 18, 2024
15 of 16 checks passed
@jderusse jderusse deleted the fix-phpunit branch June 18, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant