Add SQS AddPermission operation #1773
Draft
+346
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You need to write the tests. |
|
Test added. I seem to be failing the change log test. I added an entry, but perhaps not the right format? Any advice? |
You can ignore the The |
jderusse
reviewed
Oct 1, 2024
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| - Enable compiler optimization for the `sprintf` function. | |||
| - Avoid calls to spl_object_ methods when computing cache key. | |||
| - Add Sqs AddPermission operation | |||
There was a problem hiding this comment.
You changed the wrong CHANGELOG file. This one is fore changes in the Core sub package.
You should edit the ./src/Service/Sqs/CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New SQS AddPermission operation, required to allow 3rd parties the permission to send messages to queues created using the createQueue endpoint.
I didn't seem to need to do anything after using the generate script - very cool. Let me know if I've missed anything.
As it looks like you are using a monorepo how would I go about using my fork of that in my code while the PR is reviewed and hopefully accepted.
Thanks
Steve