Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support json token uri #901

Merged
merged 7 commits into from
Oct 7, 2024
Merged

feat: support json token uri #901

merged 7 commits into from
Oct 7, 2024

Conversation

}
}
}
function detechTokenUriFormat(token_uri: string) {
if (token_uri.split(',')[0] === SUPPORT_DECODED_TOKEN_URI.BASE64) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

startWiths

@@ -172,12 +177,31 @@ export async function getMetadata(token_uri: string): Promise<{
image?: string;
animation_url?: string;
}> {
const tokenUriType = detechTokenUriFormat(token_uri);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detect

@@ -172,12 +177,31 @@ export async function getMetadata(token_uri: string): Promise<{
image?: string;
animation_url?: string;
}> {
const tokenUriType = detechTokenUriFormat(token_uri);
switch (tokenUriType) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gộp vào hàm detect, trả ra kết quả là string, expect là json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sửa cái raw true ở github

@phamphong9981
Copy link
Collaborator Author

phamphong9981 commented Sep 30, 2024

@peara Pull này chưa xong anh nhé, có phần 3 của issue này đã trong pull, phần 1 và 2 chưa có, em sửa nốt ạ
#903

@peara peara merged commit 934015c into evm Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants