Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and reminders #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes and reminders #6

wants to merge 1 commit into from

Conversation

davkoh
Copy link

@davkoh davkoh commented Aug 29, 2023

No description provided.

@@ -7,7 +7,7 @@ Currently there are demos for BDA3 Chapters 2, 3, 4, 5, 6, 10, 11 and 12.
Furthermore there are demos for
[CmdStanR](https://github.com/stan-dev/cmdstanr),
[RStan](https://github.com/stan-dev/rstan)
[RStanARM](https://github.com/stan-dev/rstanarm).
[RStanARM](https://github.com/stan-dev/rstanarm). When running the R-scripts from Aalto Jupyter notebook, please make sure to set the parent directory to "~/notebooks/BDA_R_demos".
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make this automatic

@@ -20,7 +20,7 @@ library(gridExtra)
library(tidyr)
library(latex2exp)
library(rprojroot)
root<-has_file(".BDA_R_demos_root")$make_fix_file()
root<-has_file(".BDA_R_demos_root")$make_fix_file() # Make sure to set parent directory to ~/notebooks/BDA_R_demos
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should make this automatic

@@ -81,7 +81,7 @@ plot_margpost <-
geom_line(aes(x = x, y = p), color='forestgreen') +
labs(x = expression(tau), y = TeX('$p(\\tau | y)$'), title = title1) +
scale_y_continuous(breaks = 0) +
xlim(c(0, 35))
xlim(c(0, 40))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this change needed?

@@ -1,5 +1,7 @@
# Links to html versions of demos

If running the CMDStanR demos on Aalto Jupyter, please make sure to have specified the location for CMDStanR: set_cmdstan_path('/coursedata/cmdstan').
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work automatically as soon as IT has fixed it

@@ -194,7 +194,7 @@ mcmc_hist(draws_bin2, pars='oddsratio')
#' # Linear Gaussian model
#'
#' The following file has Kilpisjärvi summer month temperatures 1952-2013:
data_kilpis <- read.delim('kilpisjarvi-summer-temp.csv', sep = ';')
data_kilpis <- read.delim('~/BDA_R_demos/demos_rstan/kilpisjarvi-summer-temp.csv', sep = ';')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fixed absolute paths!

@@ -284,7 +284,7 @@ loo_compare(loo1, loo2)
#' # Comparison of k groups with hierarchical models
#'
#' Let's compare the temperatures in three summer months.
data_kilpis <- read.delim('kilpisjarvi-summer-temp.csv', sep = ';')
data_kilpis <- read.delim('~/BDA_R_demos/demos_rstan/kilpisjarvi-summer-temp.csv', sep = ';')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fixed absolute paths!

@@ -239,7 +239,7 @@ mcmc_hist(draws_bin2, pars='oddsratio')
The following file has Kilpisjärvi summer month temperatures 1952-2013:

```{r }
data_kilpis <- read.delim('kilpisjarvi-summer-temp.csv', sep = ';')
data_kilpis <- read.delim('~/BDA_R_demos/demos_rstan/kilpisjarvi-summer-temp.csv', sep = ';')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fixed absolute paths!

@@ -348,7 +348,7 @@ There is no practical difference between Gaussian and Student's t models.
Let's compare the temperatures in three summer months.

```{r }
data_kilpis <- read.delim('kilpisjarvi-summer-temp.csv', sep = ';')
data_kilpis <- read.delim('~/BDA_R_demos/demos_rstan/kilpisjarvi-summer-temp.csv', sep = ';')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No fixed absolute paths!

@avehtari
Copy link
Owner

avehtari commented Oct 2, 2023

I noticed this open PR with several unresolved conversations. @davkoh ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants