-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for action icons and action divider #185
Conversation
gabrielgiroe1
commented
Apr 1, 2024
•
edited
Loading
edited
✅ Deploy Preview for avo-v2-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
72ca5ac
to
e49efc4
Compare
Closing in favor of #187 ( couldn't commit on that PR ) |
@@ -362,6 +362,47 @@ end | |||
``` | |||
::: | |||
|
|||
:::option `action icons` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other labels have only the option name. Theis would be icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrianthedev the other options on actions are response types I changed the icon an divider location in this PR #187
I couldn't commit to this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that, but I think we should do the same with these arguments.
Maybe in a docs reorganization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agree, just created this issue to track it #195