iox128a1u.h: Update ADC bit definitions and channel structs #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bit names disagreed with their counterparts in the datasheet. In other cases, enums were cut short causing entire modes of operation to be completely omitted. The ADC_CH_t struct was missing the SCAN byte, which led the entire ADC_t struct to be misaligned with the actual locations of latter registers in memory.
lmorrisonnautel
commented
May 15, 2024
Correct ADC_CH_MUXNEG_PIN3_gc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bit names disagreed with their counterparts in the datasheet. In other cases, enums were cut short causing entire modes of operation to be completely omitted.
The ADC_CH_t struct was missing the SCAN byte, which led the entire ADC_t struct to be misaligned with the actual locations of latter registers in memory.