-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): enhanced monitoring configuration at the cluster level #32157
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32157 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 105 105
Lines 7163 7163
Branches 1311 1311
=======================================
Hits 5529 5529
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
None
Reason for this change
AWS RDS now supports the configuration of advanced monitoring at the cluster level.
https://aws.amazon.com/about-aws/whats-new/2024/09/amazon-rds-performance-insights-supports-aurora-cluster-level-configuration/?nc1=h_ls
This feature is essential for creating limitless database cluster. (#32151)
Description of changes
I added
enableClusterLevelEnhancedMonitoring
prop toClusterProps
.If this prop enabled,
monitoringInterval
andmonitoringRole
is applied to not the instances but the cluster.Enhanced monitoring configuration for the cluster and instances has some restrictions.
monitoringRoleArn
for both the cluster and instances, the values must be identical.monitoringInterval
for both the cluster and instances, the values must be identical.monitoringInterval
ormonitoringRoleArn
is set at the cluster level, enhanced monitoring will be enabled even if the same values are not specified for the instances.Based on the above, I decided to add a flag (
enableClusterLevelEnhancedMonitoring
) to switch the application ofmonitoringInterval
andmonitoringRole
between the instance level and the cluster level to avoid breaking changes to the existing props.Verification Results Memo
The value of the Enhanced Monitoring configuration must be the same for both the cluster level and the instance level.
The monitoring role arn must be the same for both cluster and instance level.
Resource handler returned message: "MonitoringRoleArn conflicts with cluster level parameter. (Service: Rds, Status Code: 400, Request ID: 761a867d-409e-4208-a08e-5591607d0ed0)" (RequestToken: fb691324-f37c-405d-e5bd-447911f7664f, HandlerErrorCode: InvalidRequest)
Description of how you validated changes
Add both unit and integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license