Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-lambda-cpp to 0.2.7 #67

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tl-hbk
Copy link

@tl-hbk tl-hbk commented Feb 7, 2022

Was having the following issue when building awslabs/aws-lambda-cpp#93 which is fixed in aws-lambda-cpp 0.2.7

The following patches were deleted as they were already merged upstream in aws-lambda-cpp

  • aws-lambda-cpp-make-the-runtime-client-user-agent-overrideable.patch - Commit
  • aws-lambda-cpp-make-lto-optional.patch - Commit

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tl-hbk
Copy link
Author

tl-hbk commented Feb 7, 2022

Unrelated but when I ran update_deps.sh the download for curl was broken. It seems like it works when the periods in the version string are replaced with underscores in the url

https://github.com/curl/curl/archive/curl-7.78.0.tar.gz - broken
https://github.com/curl/curl/archive/curl-7_78_0.tar.gz - working

EDIT: It does seem like the second url is pointing to a different archive than what's checked into git. What's in git seems to be the archive at https://github.com/curl/curl/releases/download/curl-7_78_0/curl-7.78.0.tar.gz

@zsombor-balogh
Copy link
Contributor

Unrelated but when I ran update_deps.sh the download for curl was broken. It seems like it works when the periods in the version string are replaced with underscores in the url

https://github.com/curl/curl/archive/curl-7.78.0.tar.gz - broken https://github.com/curl/curl/archive/curl-7_78_0.tar.gz - working

EDIT: It does seem like the second url is pointing to a different archive than what's checked into git. What's in git seems to be the archive at https://github.com/curl/curl/releases/download/curl-7_78_0/curl-7.78.0.tar.gz

Thanks for pointing out, it's been addressed.

@zsombor-balogh
Copy link
Contributor

Thank you for your contribution! It looks like deps/versions is conflicting with a recent libcurl update, would you mind resolving the conflict?

@tl-hbk
Copy link
Author

tl-hbk commented May 4, 2022

@zsombor-balogh resolved the conflict

@tl-hbk
Copy link
Author

tl-hbk commented May 5, 2022

Build errors seem to be related to this
awslabs/aws-lambda-cpp#124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants