Add ML-KEM 512, 768, and 1024 #539
Open
+215
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
force-pushed
the
ml-kem
branch
2 times, most recently
from
021e1cd
to
b474f2a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 95.80% 92.62% -3.18%
==========================================
Files 61 67 +6
Lines 8143 9366 +1223
Branches 0 9366 +9366
==========================================
+ Hits 7801 8675 +874
- Misses 342 420 +78
- Partials 0 271 +271 ☔ View full report in Codecov by Sentry. |
justsmth
previously approved these changes
Oct 2, 2024
Comment on lines
+113
to
+118
| #[cfg(feature = "fips")] | ||
| mod missing_nid { | ||
| pub const NID_MLKEM512: i32 = 988; | ||
| pub const NID_MLKEM768: i32 = 989; | ||
| pub const NID_MLKEM1024: i32 = 990; | ||
| } |
There was a problem hiding this comment.
Is this to account for any AWS-LC versions that may have the NID_MLKEM* define missing?
There was a problem hiding this comment.
Correct. aws-lc-fips-sys is aligned with the AWS-LC-FIPS 2.0.x, which doesn't provide these constants.
Co-authored-by: Samuel Chiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
Describe current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.