Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable BR 128 to 129 Stacked ETCD Upgrade (#7722) #7723

Conversation

jonathanmeier5
Copy link
Member

@jonathanmeier5 jonathanmeier5 commented Feb 27, 2024

Issue #, if available:

Manual cherry pick into release-0.19 because patch does not apply cleanly.
#7722 (comment)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@taneyland
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: taneyland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-0.19@97053a9). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.19    #7723   +/-   ##
===============================================
  Coverage                ?   73.61%           
===============================================
  Files                   ?      588           
  Lines                   ?    37177           
  Branches                ?        0           
===============================================
  Hits                    ?    27369           
  Misses                  ?     8016           
  Partials                ?     1792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot merged commit 0bd324e into aws:release-0.19 Feb 27, 2024
9 checks passed
sp1999 pushed a commit to sp1999/eks-anywhere that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants