Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable codeql for github actions #5316

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This change adds CodeQL scanning for Github Actions specified in this repo to check for things like Github Action pinning and script injection. More details here: https://github.blog/2023-08-09-four-tips-to-keep-your-github-actions-workflows-secure/#2-enable-code-scanning-for-workflows

How was this change tested?

Create script injection vulnerabilities on fork and test that CodeQL can catch these

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 38d5ed8
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6579e924bcfc950008cf8506

@jonathan-innis jonathan-innis enabled auto-merge (squash) December 13, 2023 08:55
@coveralls
Copy link

coveralls commented Dec 13, 2023

Pull Request Test Coverage Report for Build 7198852545

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.489%

Totals Coverage Status
Change from base Build 7191525566: 0.0%
Covered Lines: 4918
Relevant Lines: 5962

💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the codeql-github-actions branch 4 times, most recently from 5fedfec to cdaa70c Compare December 13, 2023 17:05
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis merged commit a9a1557 into aws:main Dec 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants