Skip to content

Commit

Permalink
fix(s2n-quic-transport): wait until handshake is confirmed to start M…
Browse files Browse the repository at this point in the history
…TU probing (#2305)

* fix(s2n-quic-transport): wait until handshake is confirmed to start MTU probing

* don't run mtls test on windows
  • Loading branch information
WesleyRosenblum authored Aug 26, 2024
1 parent 8f7c04b commit b4ba62d
Show file tree
Hide file tree
Showing 2 changed files with 194 additions and 146 deletions.
3 changes: 2 additions & 1 deletion quic/s2n-quic-transport/src/connection/connection_impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -867,11 +867,12 @@ impl<Config: endpoint::Config> connection::Trait for ConnectionImpl<Config> {
let mut outcome = transmission::Outcome::default();
let path_id = self.path_manager.active_path_id();

// Send an MTU probe if necessary and the handshake has completed
// Send an MTU probe if necessary and the handshake has been confirmed
// MTU probes are prioritized over other data so they are not blocked by the
// congestion controller, as they are critical to achieving maximum throughput.
if self.state == ConnectionState::Active
&& self.path_manager.active_path().can_transmit(timestamp)
&& self.space_manager.is_handshake_confirmed()
&& self
.path_manager
.active_path()
Expand Down
Loading

0 comments on commit b4ba62d

Please sign in to comment.