fix(s2n-quic-rustls): mark re-exported types as deprecated #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
camshaft/rustls-deprecated
branch
from
754bfd0
to
a6fb91b
Compare
toidiu
approved these changes
Apr 5, 2024
WesleyRosenblum
approved these changes
Apr 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Our rustls TLS provider re-exported the
rustlscrate in order to give customers more flexibility when configuring their TLS backend. However, this meant that we were shipping with the rustls API in thes2n-quiccrate. Each timerustlshas a breaking change, it ends up breaking the s2n-quic 1.x stability guarantees.In hindsight, it was probably a mistake to re-export a dependency's API (especially pre-1.x) and this PR corrects that by marking those exports as deprecated.
This change also adds a
with_prefer_server_cipher_suite_orderoption to therustlsTLS builder to ease migration off of the re-exportedrustlscrate.Testing:
Existing CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.