Remove --cfg s2n_quic_unstable #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cfg (intentionally) prevents a downstream library from wrapping s2n-quic unstable API internally without the final build explicitly opting into that instability. Unfortunately, with s2n-quic-dc, we are going to be doing exactly that. For the time being drop the cfg entirely. Since it's only set to allow unstable features, we should technically be able to revert this change at some point (e.g., if dc stops depending on unstable surface area): it would be fairly similar to just breaking consumers of those unstable features, which is already allowed.
camshaft
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cfg (intentionally) prevents a downstream library from wrapping s2n-quic unstable API internally without the final build explicitly opting into that instability. Unfortunately, with s2n-quic-dc, we want to do exactly that. Essentially we'll be treating
s2n-quicfroms2n-quic-dcthe same way we treats2n-quic-corefroms2n-quic.For the time being drop the cfg entirely. Since it's only set to allow unstable features, we should technically be able to revert this change at some point (e.g., if dc stops depending on unstable surface area): it would be fairly similar to just breaking consumers of those unstable features, which is already allowed.
Call-outs:
Not sure I caught everything in this -- mostly relying on a grep for s2n_quic_unstable and just blindly updating cfgs.
Testing:
None.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.