fix(dc-wireshark): parse all packet types in TCP #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/dc-wireshark-tcp
branch
from
863bd7e
to
7622362
Compare
Mark-Simulacrum
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change renamed the
dissect::udp_segmentfunction todissect::segmentand calls it from both UDP and TCP now. This ensures that all packet types are handled. It also can make it easier to diagnose issues if, for example, TCP is transmitting Control or Datagram packets.Testing:
I've added some sample pcaps to show it working for
UnknownPathSecretpackets.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.