deps: h3-0.0.6 (w/ tracing feature as h3-quinn) #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you run |
|
Hi @camshaft Yes, I've just done it :-) Thanks! |
camshaft
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
This change simply supports
h3v0.0.6 that updates its trait definitions and supportstracingfeature.Description of changes:
This PR changes the APIs of
s2n-quic-h3according to the update ofh3's trait definition. This also adds an optional featuretracingas the updates of the official crateh3-quinnimplementingh3traits.Call-outs:
I believe the change does not need to be updated at this point since it just follows the
h3's API changes.Testing:
Existing tests (but there is no test in
s2n-quic-h3as well ash3-quinn)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.