chore(s2n-quic): release 1.44.0 and pin bytes dependency #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
approved these changes
Aug 1, 2024
Darksonn
reviewed
Aug 1, 2024
Comment on lines
+34
to
+35
| # TODO: Unpin when https://github.com/aws/s2n-quic/issues/2289 is resolved | ||
| bytes = { version = "=1.6.1", optional = true, default-features = false } |
There was a problem hiding this comment.
As a general comment, I strongly advice not using = constraints with our crates. In this case, a ~1.6.1 constraint would have been sufficient. The bytes crate is extremely conservative about what can go in a patch release. Using = constraints results in breakage if a release is yanked, and means that you don't get updates if there's an important bugfix.
There was a problem hiding this comment.
Thanks, we'll keep that in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Version bump for 1.44.0
Call-outs:
I've also pinned
bytesto version1.6.1, see #2289By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.