Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConfirmComplete with handshake de-duplication #2307

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix ConfirmComplete with handshake de-duplication #2307

merged 1 commit into from
Aug 27, 2024

Commits on Aug 27, 2024

  1. Fix ConfirmComplete with handshake de-duplication 

    Previously, we only stored a single Waker, which meant that when the
underlying s2n-quic connection/handle was returned to applications
multiple times it ended up only waking one of the application tasks.

This modifies the ConfirmComplete logic such that we now store as many
Wakers as needed (using Tokio's watch channel) and wake all of them on
changes.
    @Mark-Simulacrum
    Mark-Simulacrum committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    ec8b7c0 View commit details
    Browse the repository at this point in the history