feat(s2n-quic-core): add metrics trait #2331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
previously approved these changes
Sep 25, 2024
| @@ -0,0 +1,17 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| /// A Recorder should arrange to emit the properties and counters on Drop into some output. |
Maybe?
I wonder if we should also note in register_counter that the counter shouldn't be used after dropping the recorder (i.e., that might be a no-op rather than incrementing a counter still). I don't think it makes sense to have the Counter borrow from the Recorder -- too constraining to manage those lifetimes -- but documenting the intended lifecycle seems like a good idea.
camshaft
force-pushed
the
metrics-trait
branch
from
be14fbf
to
8ee9589
Compare
|
Closing in favor of #2335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change adds a
Metrictrait to enable future integration with metric systems.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.