chore(s2n-quic-crypto): remove ring #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
reviewed
Sep 25, 2024
| @@ -17,18 +17,13 @@ fips = ["aws-lc-rs/fips"] | |||
| testing = [] | |||
|
|
|||
| [dependencies] | |||
| aws-lc-rs = { version = "1.9", features = ["prebuilt-nasm"] } | |||
There was a problem hiding this comment.
I think we only want to enable this is our dev-dependencies? The problem with features is they are only additive and this would make it difficult for someone to opt out of this
There was a problem hiding this comment.
If its not on by default, wouldn't windows builds start breaking?
Could we add prebuilt-nasm as a default feature on s2n-quic, so customers can opt out by turning off default features?
There was a problem hiding this comment.
Yeah I guess this is part of the reason we haven't made the change. Well I guess today it's no worse than what windows environments get with ring... So let's move forward as-is and we can revisit the default-features = false route.
camshaft
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Since aws/aws-lc#1477 was addressed,
aws-lc-rscan now build on Windows without requiring NASM to be installed. This was the last hurdle before removing our dependency onring, so this PR does that.Call-outs:
Including
prebuilt-nasmas a feature makes it difficult to opt out of this functionality, so we may want to bump it up to ans2n-quiclevel feature in the futureTesting:
Builds in CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.