feat(s2n-quic-platform): emit socket events #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/socket-errors
branch
4 times, most recently
from
1b05294
to
5032286
Compare
| @@ -54,6 +62,10 @@ where | |||
| }}; | |||
| } | |||
|
|
|||
| publisher!(clock.get_time()).on_platform_started(event::builder::PlatformStarted { | |||
There was a problem hiding this comment.
would on_platform_event_loop_started be too wordy? its more aligned with on_platform_event_loop_wakeup
camshaft
force-pushed
the
camshaft/socket-errors
branch
from
5032286
to
c9a0806
Compare
WesleyRosenblum
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change restores the functionality of emitting the
Platformevents. When we refactored the IO model to process socket syscalls in a separate task from the endpoint these events were lost. This can cause visibility issues when debugging why packets aren't being sent/received.Call-outs:
I've also emitted a
PlatformStaredevent that emits the IP/port that the endpoint is listening on. This should also help debugging.Testing:
I've added a snapshot test to make sure all of the endpoint-level events are being emitted.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.