Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(s2n-quic-dc): add tests for map events #2363

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented Oct 31, 2024

Description of changes:

This change adds several snapshot tests to the map events.

Call-outs:

In order to actually implement this I had to:

  • Add support for redacting fields in a snapshot, as they are random values
  • implementing Subscriber for Arc<T> where T: Subscriber
  • Add a testing method that generates a pair of secrets given 2 maps, since they can't actually send packets to themselves since secrets are unidirectional

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@camshaft camshaft marked this pull request as ready for review October 31, 2024 23:06
Mark-Simulacrum
Mark-Simulacrum previously approved these changes Nov 1, 2024
@camshaft camshaft enabled auto-merge (squash) November 1, 2024 17:03
@camshaft camshaft merged commit 65d55a4 into main Nov 1, 2024
130 checks passed
@camshaft camshaft deleted the camshaft/dc-event-tests branch November 1, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants