Add implementation of delegating RequestStreamHandler #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are failing tests. @olegz Could you please take a look? |
olegz
force-pushed
the
spring-handler
branch
2 times, most recently
from
76394c0
to
123a1b4
Compare
sapessi
reviewed
Jun 30, 2023
| EndpointConfiguration: REGIONAL | ||
|
|
||
|
|
||
| Resources: |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
StageName contains invalid characters (Pattern: ^[a-zA-Z0-9-_]+$) at Resources/ServerlessHttpApiApiGatewayDefaultStage/Properties/StageName
mbfreder
approved these changes
Jul 3, 2023
valerena
requested changes
Jul 3, 2023
| @@ -29,10 +29,11 @@ public class AwsProxyRequest { | |||
| //------------------------------------------------------------- | |||
|
|
|||
| private String body; | |||
| private String resource; | |||
| private String version; | |||
| private String resource; | |||
Comment on lines
100
to
105
| return version; | ||
| } | ||
|
|
||
| public void setVersion(String version) { | ||
| this.version = version; | ||
| } |
Comment on lines
290
to
306
| <repository> | ||
| <id>spring-snapshots</id> | ||
| <name>Spring Snapshots</name> | ||
| <url>https://repo.spring.io/snapshot</url> | ||
| <snapshots> | ||
| <enabled>true</enabled> | ||
| </snapshots> | ||
| </repository> | ||
| <repository> | ||
| <id>spring-milestones</id> | ||
| <name>Spring Milestones</name> | ||
| <url>https://repo.spring.io/milestone</url> | ||
| <snapshots> | ||
| <enabled>false</enabled> | ||
| </snapshots> | ||
| </repository> | ||
| </repositories> |
| */ | ||
| public class SpringDelegatingLambdaContainerHandler implements RequestStreamHandler { | ||
|
|
||
| private final Class<?>[] startupClasses; |
There was a problem hiding this comment.
Most of this file has tabs instead of spaces
| @SuppressWarnings("rawtypes") | ||
| public class SpringDelegatingLambdaContainerHandlerTests { | ||
|
|
||
| private static String API_GATEWAY_EVENT = "{\n" |
There was a problem hiding this comment.
This whole file has tabs instead of spaces.
|
|
||
| @Bean("CognitoIdentityFilter") | ||
| public Filter cognitoFilter() { | ||
| return new CognitoIdentityFilter(); |
There was a problem hiding this comment.
There's a single tab here (4 spaces followed by a tab)
valerena
approved these changes
Jul 5, 2023
This new handler delegates to spring-cloud-function-serverless-web module which is managed by Spring team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new handler delegates to spring-cloud-function-serverless-web module which is managed by Spring team
This PR is a substitution for the one I canceled #578 and is better in a way that it requires user to opt-in to use this handler. The current AWS code is not touched providing a very smooth and safe transition.
I will also be publishing a sample on how to use it
By submitting this pull request