feat: save artifact size metrics task #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
approved these changes
Apr 26, 2024
lauzadis
approved these changes
Apr 26, 2024
| val artifactSizeMetrics = ByteStream.fromString(metricsFile.get().asFile.readText()) | ||
|
|
||
| runBlocking { | ||
| S3Client.fromEnvironment().use { s3 -> |
There was a problem hiding this comment.
I just realized we don't specify the client region anywhere, I hope that will be consistently set by the environment (i.e env var)
There was a problem hiding this comment.
It is, it's set by this line in the workflow:
https://github.com/awslabs/aws-sdk-kotlin/blob/6f0da00781485b0921e0f98410876b191b39821d/.github/workflows/codebuild-ci.yml#L80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add new task to save artifact size metrics using gradle plugin.
See: awslabs/aws-crt-kotlin#102 (comment)
Also some minor simplifications
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.