misc: expand allow-list, apply signing plugin only when required #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct group ID to log message
0marperez
approved these changes
Sep 26, 2024
ianbotsf
reviewed
Sep 26, 2024
Comment on lines
43
to
44
| "pluginMaven", | ||
| "dynamodb-mapper-schema-generatorPluginMarkerMaven", |
There was a problem hiding this comment.
Question: What are these two?
There was a problem hiding this comment.
These are publications that I noticed weren't being configured (log.warn message), I believe they come from the gradle-plugin-publish plugin for the schema generator. dynamodb-mapper-schema-generatorPluginMarkerMaven was not necessary so I removed it, without pluginMaven the plugin is unaccessible though.
There was a problem hiding this comment.
Actually, I was just able to remove both of these. Not sure when this changed, but at some point these were required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.