Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RNSCommission): allow send 0 #286

Open
wants to merge 9 commits into
base: feature/bulk-renew
Choose a base branch
from
+255 −565
Open

fix(RNSCommission): allow send 0 #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d26bef2
fix(RNSCommission): return if sent RON when zero instead of revert
TuDo1403 Nov 5, 2024
9bfd059
Merge branch 'feature/bulk-renew' into fix/return-when-zero-rns-commi…
TuDo1403 Nov 5, 2024
a57b30c
chore: add uint test for transfer 0 ron
tringuyenskymavis Nov 5, 2024
6397bef
chore: add more assertion
tringuyenskymavis Nov 5, 2024
7833277
script: upgrade mainnet script
tringuyenskymavis Nov 5, 2024
c91ecfd
chore: correct date
tringuyenskymavis Nov 5, 2024
bcd9fce
chore: correct name
tringuyenskymavis Nov 5, 2024
5dbcc0b
chore: add assertions
tringuyenskymavis Nov 5, 2024
49e1e15
chore: add deployment artifact for RNSCommission on ronin-mainnet
TuDo1403 Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions broadcast/20241105_UpgradRNSCommissionMainnet.sol/2020/run-1730866136.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{
"transactions": [
{
"hash": "0x0b6223f4072c1d6788afbf72905edd47e052113fb0b5492be769233aba223032",
"transactionType": "CREATE",
"contractName": "RNSCommission",
"contractAddress": "0x6132f68e5084258ceb12e4d5ede772f544b81f92",
"function": null,
"arguments": null,
"transaction": {
"from": "0x08295771719b138a241f45023b13cc868d72827d",
"gas": "0x31f87e",
"value": "0x0",
"input": "0x608060405234801561001057600080fd5b5061001961001e565b6100dd565b600054610100900460ff161561008a5760405162461bcd60e51b815260206004820152602760248201527f496e697469616c697a61626c653a20636f6e747261637420697320696e697469604482015266616c697a696e6760c81b606482015260840160405180910390fd5b60005460ff908116146100db576000805460ff191660ff9081179091556040519081527f7f26b83ff96e1f2b6a682f133852f6798a09c465da95921460cefb38474024989060200160405180910390a15b565b611c30806100ec6000396000f3fe6080604052600436106100ec5760003560e01c806391cbc73f1161008a578063c42ef38c11610059578063c42ef38c14610297578063ca15c873146102cb578063d547741f146102eb578063e92108b51461030b57600080fd5b806391cbc73f1461022257806391d14854146102425780639fd50e5814610262578063a217fddf1461028257600080fd5b806336568abe116100c657806336568abe146101945780634c255c97146101b45780635dc30fe5146101ca5780639010d07c146101ea57600080fd5b806301ffc9a714610100578063248a9ca3146101355780632f2ff15d1461017457600080fd5b366100fb576100f961032d565b005b600080fd5b34801561010c57600080fd5b5061012061011b36600461130e565b610367565b60405190151581526020015b60405180910390f35b34801561014157600080fd5b50610166610150366004611338565b6000908152600160208190526040909120015490565b60405190815260200161012c565b34801561018057600080fd5b506100f961018f366004611366565b610392565b3480156101a057600080fd5b506100f96101af366004611366565b6103bd565b3480156101c057600080fd5b5061016661271081565b3480156101d657600080fd5b506100f96101e53660046113e2565b610440565b3480156101f657600080fd5b5061020a610205366004611424565b610455565b6040516001600160a01b03909116815260200161012c565b34801561022e57600080fd5b506100f961023d366004611446565b610474565b34801561024e57600080fd5b5061012061025d366004611366565b610605565b34801561026e57600080fd5b506100f961027d3660046114c9565b610630565b34801561028e57600080fd5b50610166600081565b3480156102a357600080fd5b506101667f76d12de99ad2ca162840505be9b657c2e7a650cc3ee0284048f3f9def3c1adf281565b3480156102d757600080fd5b506101666102e6366004611338565b61074e565b3480156102f757600080fd5b506100f9610306366004611366565b610765565b34801561031757600080fd5b5061032061078b565b60405161012c91906115a2565b6103577f76d12de99ad2ca162840505be9b657c2e7a650cc3ee0284048f3f9def3c1adf233610605565b15610365576103653461089c565b565b60006001600160e01b03198216635a05180f60e01b148061038c575061038c82610a87565b92915050565b600082815260016020819052604090912001546103ae81610abc565b6103b88383610ac9565b505050565b6001600160a01b03811633146104325760405162461bcd60e51b815260206004820152602f60248201527f416363657373436f6e74726f6c3a2063616e206f6e6c792072656e6f756e636560448201526e103937b632b9903337b91039b2b63360891b60648201526084015b60405180910390fd5b61043c8282610aeb565b5050565b600061044b81610abc565b6103b88383610b0d565b600082815260026020526040812061046d9083610c90565b9392505050565b600054610100900460ff16158080156104945750600054600160ff909116105b806104ae5750303b1580156104ae575060005460ff166001145b6105115760405162461bcd60e51b815260206004820152602e60248201527f496e697469616c697a61626c653a20636f6e747261637420697320616c72656160448201526d191e481a5b9a5d1a585b1a5e995960921b6064820152608401610429565b6000805460ff191660011790558015610534576000805461ff0019166101001790555b61053f600087610c9c565b8160005b818110156105ab5761059b7f76d12de99ad2ca162840505be9b657c2e7a650cc3ee0284048f3f9def3c1adf28686848181106105815761058161162a565b90506020020160208101906105969190611640565b610c9c565b6105a481611673565b9050610543565b506105b68686610b0d565b5080156105fd576000805461ff0019169055604051600181527f7f26b83ff96e1f2b6a682f133852f6798a09c465da95921460cefb38474024989060200160405180910390a15b505050505050565b60009182526001602090815260408084206001600160a01b0393909316845291905290205460ff1690565b600061063b81610abc565b603554851061065d57604051634ec4810560e11b815260040160405180910390fd5b6001600160a01b0384166106845760405163e99d5ac560e01b815260040160405180910390fd5b83603586815481106106985761069861162a565b906000526020600020906003020160000160006101000a8154816001600160a01b0302191690836001600160a01b031602179055508282603587815481106106e2576106e261162a565b90600052602060002090600302016002019182610700929190611722565b5084336001600160a01b03167faa3076bb2e00a425a96ce6aa8762a984fe8ed14922e3fba98cfa90683cb05ff886868660405161073f9392919061180c565b60405180910390a35050505050565b600081815260026020526040812061038c90610ca6565b6000828152600160208190526040909120015461078181610abc565b6103b88383610aeb565b60606035805480602002602001604051908101604052809291908181526020016000905b82821015610893576000848152602090819020604080516060810182526003860290920180546001600160a01b0316835260018101549383019390935260028301805492939291840191610802906116a2565b80601f016020809104026020016040519081016040528092919081815260200182805461082e906116a2565b801561087b5780601f106108505761010080835404028352916020019161087b565b820191906000526020600020905b81548152906001019060200180831161085e57829003601f168201915b505050505081525050815260200190600101906107af565b50505050905090565b806000036108a75750565b60355460008190036108cc57604051634ec4810560e11b815260040160405180910390fd5b60006108d960018361183a565b90506000805b828110156109ce57600061091786603584815481106109005761090061162a565b906000526020600020906003020160010154610cb0565b9050610923818461184d565b925061095b6035838154811061093b5761093b61162a565b60009182526020909120600390910201546001600160a01b031682610cc9565b6035828154811061096e5761096e61162a565b6000918252602091829020600390910201546040518381526001600160a01b03909116917fb649c98f58055c520df0dcb5709eff2e931217ff2fb1e21376130d31bbb1c0af910160405180910390a2506109c781611673565b90506108df565b5083811015610a8157610a16603583815481106109ed576109ed61162a565b60009182526020909120600390910201546001600160a01b0316610a11838761183a565b610cc9565b60358281548110610a2957610a2961162a565b60009182526020909120600390910201546001600160a01b03167fb649c98f58055c520df0dcb5709eff2e931217ff2fb1e21376130d31bbb1c0af610a6e838761183a565b6040519081526020015b60405180910390a25b50505050565b60006001600160e01b03198216637965db0b60e01b148061038c57506301ffc9a760e01b6001600160e01b031983161461038c565b610ac68133610d2e565b50565b610ad38282610d61565b60008281526002602052604090206103b89082610dcc565b610af58282610de1565b60008281526002602052604090206103b89082610e48565b806000819003610b3057604051634ec4810560e11b815260040160405180910390fd5b610b3c6035600061126e565b6000805b82811015610c32576000858583818110610b5c57610b5c61162a565b9050602002810190610b6e9190611860565b610b7c906020810190611640565b6001600160a01b031603610ba35760405163e99d5ac560e01b815260040160405180910390fd5b848482818110610bb557610bb561162a565b9050602002810190610bc79190611860565b610bd590602001358361184d565b91506035858583818110610beb57610beb61162a565b9050602002810190610bfd9190611860565b815460018101835560009283526020909220909160030201610c1f8282611880565b505080610c2b90611673565b9050610b40565b506127108114610c555760405163648564d360e01b815260040160405180910390fd5b336001600160a01b03167f28d7f0d68cf2a192abb8ce94479d236f99759d18e31ee7cbfb0a473764374c008585604051610a789291906119aa565b600061046d8383610e5d565b61043c8282610ac9565b600061038c825490565b6000612710610cbf8385611a7c565b61046d9190611a93565b6000610cd58383610e87565b9050806103b857610cee836001600160a01b0316610efd565b610cf783610f13565b604051602001610d08929190611ab5565b60408051601f198184030181529082905262461bcd60e51b825261042991600401611b33565b610d388282610605565b61043c57610d4581610efd565b610d50836020610f26565b604051602001610d08929190611b46565b610d6b8282610605565b61043c5760008281526001602081815260408084206001600160a01b0386168086529252808420805460ff19169093179092559051339285917f2f8788117e7eff1d82e926ec794901d17c78024a50270940304540a733656f0d9190a45050565b600061046d836001600160a01b0384166110c2565b610deb8282610605565b1561043c5760008281526001602090815260408083206001600160a01b0385168085529252808320805460ff1916905551339285917ff6391f5c32d9c69d2a47ea670b442974b53935d1edc7fd64eb21e047a839171b9190a45050565b600061046d836001600160a01b038416611111565b6000826000018281548110610e7457610e7461162a565b9060005260206000200154905092915050565b604080516000808252602082019092526001600160a01b038416908390604051610eb19190611bbb565b60006040518083038185875af1925050503d8060008114610eee576040519150601f19603f3d011682016040523d82523d6000602084013e610ef3565b606091505b5090949350505050565b606061038c6001600160a01b0383166014610f26565b606061038c82610f2284611204565b6001015b60606000610f35836002611a7c565b610f4090600261184d565b67ffffffffffffffff811115610f5857610f5861168c565b6040519080825280601f01601f191660200182016040528015610f82576020820181803683370190505b509050600360fc1b81600081518110610f9d57610f9d61162a565b60200101906001600160f81b031916908160001a905350600f60fb1b81600181518110610fcc57610fcc61162a565b60200101906001600160f81b031916908160001a9053506000610ff0846002611a7c565b610ffb90600161184d565b90505b6001811115611073576f181899199a1a9b1b9c1cb0b131b232b360811b85600f166010811061102f5761102f61162a565b1a60f81b8282815181106110455761104561162a565b60200101906001600160f81b031916908160001a90535060049490941c9361106c81611bcd565b9050610ffe565b50831561046d5760405162461bcd60e51b815260206004820181905260248201527f537472696e67733a20686578206c656e67746820696e73756666696369656e746044820152606401610429565b60008181526001830160205260408120546111095750815460018181018455600084815260208082209093018490558454848252828601909352604090209190915561038c565b50600061038c565b600081815260018301602052604081205480156111fa57600061113560018361183a565b85549091506000906111499060019061183a565b90508181146111ae5760008660000182815481106111695761116961162a565b906000526020600020015490508087600001848154811061118c5761118c61162a565b6000918252602080832090910192909255918252600188019052604090208390555b85548690806111bf576111bf611be4565b60019003818190600052602060002001600090559055856001016000868152602001908152602001600020600090556001935050505061038c565b600091505061038c565b600080608083901c1561121c5760809290921c916010015b604083901c156112315760409290921c916008015b602083901c156112465760209290921c916004015b601083901c1561125b5760109290921c916002015b600883901c1561038c5760010192915050565b5080546000825560030290600052602060002090810190610ac691905b808211156112c05780546001600160a01b03191681556000600182018190556112b760028301826112c4565b5060030161128b565b5090565b5080546112d0906116a2565b6000825580601f106112e0575050565b601f016020900490600052602060002090810190610ac691905b808211156112c057600081556001016112fa565b60006020828403121561132057600080fd5b81356001600160e01b03198116811461046d57600080fd5b60006020828403121561134a57600080fd5b5035919050565b6001600160a01b0381168114610ac657600080fd5b6000806040838503121561137957600080fd5b82359150602083013561138b81611351565b809150509250929050565b60008083601f8401126113a857600080fd5b50813567ffffffffffffffff8111156113c057600080fd5b6020830191508360208260051b85010111156113db57600080fd5b9250929050565b600080602083850312156113f557600080fd5b823567ffffffffffffffff81111561140c57600080fd5b61141885828601611396565b90969095509350505050565b6000806040838503121561143757600080fd5b50508035926020909101359150565b60008060008060006060868803121561145e57600080fd5b853561146981611351565b9450602086013567ffffffffffffffff8082111561148657600080fd5b61149289838a01611396565b909650945060408801359150808211156114ab57600080fd5b506114b888828901611396565b969995985093965092949392505050565b600080600080606085870312156114df57600080fd5b8435935060208501356114f181611351565b9250604085013567ffffffffffffffff8082111561150e57600080fd5b818701915087601f83011261152257600080fd5b81358181111561153157600080fd5b88602082850101111561154357600080fd5b95989497505060200194505050565b60005b8381101561156d578181015183820152602001611555565b50506000910152565b6000815180845261158e816020860160208601611552565b601f01601f19169290920160200192915050565b60006020808301818452808551808352604092508286019150828160051b87010184880160005b8381101561161c57888303603f19018552815180516001600160a01b031684528781015188850152860151606087850181905261160881860183611576565b9689019694505050908601906001016115c9565b509098975050505050505050565b634e487b7160e01b600052603260045260246000fd5b60006020828403121561165257600080fd5b813561046d81611351565b634e487b7160e01b600052601160045260246000fd5b6000600182016116855761168561165d565b5060010190565b634e487b7160e01b600052604160045260246000fd5b600181811c908216806116b657607f821691505b6020821081036116d657634e487b7160e01b600052602260045260246000fd5b50919050565b601f8211156103b857600081815260208120601f850160051c810160208610156117035750805b601f850160051c820191505b818110156105fd5782815560010161170f565b67ffffffffffffffff83111561173a5761173a61168c565b61174e8361174883546116a2565b836116dc565b6000601f841160018114611782576000851561176a5750838201355b600019600387901b1c1916600186901b1783556117dc565b600083815260209020601f19861690835b828110156117b35786850135825560209485019460019092019101611793565b50868210156117d05760001960f88860031b161c19848701351681555b505060018560011b0183555b5050505050565b81835281816020850137506000828201602090810191909152601f909101601f19169091010190565b6001600160a01b038416815260406020820181905260009061183190830184866117e3565b95945050505050565b8181038181111561038c5761038c61165d565b8082018082111561038c5761038c61165d565b60008235605e1983360301811261187657600080fd5b9190910192915050565b813561188b81611351565b81546001600160a01b0319166001600160a01b03919091161781556020828101356001838101919091559060028301604085013536869003601e190181126118d257600080fd5b8501803567ffffffffffffffff8111156118eb57600080fd5b80360384830113156118fc57600080fd5b6119108161190a85546116a2565b856116dc565b6000601f821160018114611946576000831561192e57508382018601355b600019600385901b1c1916600184901b17855561199f565b600085815260209020601f19841690835b8281101561197657868501890135825593880193908901908801611957565b50848210156119955760001960f88660031b161c198885880101351681555b50508683881b0185555b505050505050505050565b60208082528181018390526000906040808401600586901b8501820187855b8881101561161c57878303603f190184528135368b9003605e190181126119ef57600080fd5b8a01606081356119fe81611351565b6001600160a01b0316855281880135888601528682013536839003601e19018112611a2857600080fd5b90910187810191903567ffffffffffffffff811115611a4657600080fd5b803603831315611a5557600080fd5b8188870152611a6782870182856117e3565b968901969550505091860191506001016119c9565b808202811582820484141761038c5761038c61165d565b600082611ab057634e487b7160e01b600052601260045260246000fd5b500490565b7f5472616e7366657248656c7065723a20636f756c64206e6f74207472616e7366815269032b9102927a7103a37960b51b602082015260008351611b0081602a850160208801611552565b660103b30b63ab2960cd1b602a918401918201528351611b27816031840160208801611552565b01603101949350505050565b60208152600061046d6020830184611576565b7f416363657373436f6e74726f6c3a206163636f756e7420000000000000000000815260008351611b7e816017850160208801611552565b7001034b99036b4b9b9b4b733903937b6329607d1b6017918401918201528351611baf816028840160208801611552565b01602801949350505050565b60008251611876818460208701611552565b600081611bdc57611bdc61165d565b506000190190565b634e487b7160e01b600052603160045260246000fdfea2646970667358221220e5a364b75fc6893bc3ff77c8c2c91c3d45566661b28843887c78f343594f602664736f6c63430008150033",
"nonce": "0x3e",
"chainId": "0x7e4"
},
"additionalContracts": [],
"isFixedGasLimit": false
}
],
"receipts": [
{
"status": "0x1",
"cumulativeGasUsed": "0x3b9a39",
"logs": [
{
"address": "0x6132f68e5084258ceb12e4d5ede772f544b81f92",
"topics": [
"0x7f26b83ff96e1f2b6a682f133852f6798a09c465da95921460cefb3847402498"
],
"data": "0x00000000000000000000000000000000000000000000000000000000000000ff",
"blockHash": "0x337dde8d17ff1633983d01fba6a16e57ebc88ac39df7a1cfb039e21c2587e52b",
"blockNumber": "0x25d64e9",
"transactionHash": "0x0b6223f4072c1d6788afbf72905edd47e052113fb0b5492be769233aba223032",
"transactionIndex": "0x15",
"logIndex": "0x37",
"removed": false
}
],
"logsBloom": "0x00000000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000080000000000000000000000000000000000000000000008400000000000000000080000000000000000000000000000000000000000000040000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"type": "0x0",
"transactionHash": "0x0b6223f4072c1d6788afbf72905edd47e052113fb0b5492be769233aba223032",
"transactionIndex": "0x15",
"blockHash": "0x337dde8d17ff1633983d01fba6a16e57ebc88ac39df7a1cfb039e21c2587e52b",
"blockNumber": "0x25d64e9",
"gasUsed": "0x18fc3f",
"effectiveGasPrice": "0x4a817c800",
"from": "0x08295771719b138a241f45023b13cc868d72827d",
"to": null,
"contractAddress": "0x6132f68e5084258ceb12e4d5ede772f544b81f92"
}
],
"libraries": [],
"pending": [],
"returns": {},
"timestamp": 1730866136,
"chain": 2020,
"commit": "5dbcc0b"
}
Loading
Loading