-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Info.plist.patch #1323
base: BRANCH_2_7_X
Are you sure you want to change the base?
Update Info.plist.patch #1323
Conversation
The FSF address has changed. Replaced both files with versions downloaded from the FSF.
Updated GPLv2 and LGPLv2.1 license files
Add retina display support for OSX. More information can be found here: https://developer.apple.com/library/content/documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/Explained/Explained.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sebastian, thanks for the patch. I can't test it immediately because I have no access to Mac Book with retina display, but I trust that it fixes the issue.
Just one moment: can you make a pull request against BRANCH_2_7_X instead of master? BRANCH_2_7_X is a stable branch, and I'd like to merge stable into master later, rather than merge or cherry-pick from master into stable branch.
Thanks!
Hello Dmitry Appreciate. It is working here on my MBP and shows the high resolution. |
Hi, I meant that you do in your local repository
and then create a pull request where base is However, if you feel that it is too much for a one line change and don't care about your activity history ;) then I can add it appropriately myself. |
Hi,
I try to do it the way you want. Everything ok?
… Am 29.11.2016 um 01:23 schrieb Dmitry Barashev ***@***.*** ***@***.***>>:
Hi,
this base branch change is not exactly what I meant.
I meant that you do in your local repository
git checkout BRANCH_2_7_X
# add your changes
git commit -a
git push origin BRANCH_2_7_X
and then create a pull request where base is bardsoftware:BRANCH_2_7_X and from is ryanthara:BRANCH_2_7_X
However, if you feel that it is too much for a one line change and don't care about your activity history ;) then I can add it appropriately myself.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1323 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGyZEFhxmCkEj1azOsv-F-gfSw3zWwZ7ks5rC3CKgaJpZM4K9aGB>.
|
thanks to @ryanthara for the patch See original pull request: pr:#1323
I have commmited this change myself. You can download the build with this change applied from Dropbox: https://www.dropbox.com/sh/0gwuayq6vg0kyss/AAApogLPlvpg0lY9JltS-3sZa?dl=0 (there is zipped GanttProject.app) |
Your implementation doesn't work. The NSHighResolutionCapable is not on the right position and therefore the version on the dropbox doesn't start in retina mode. Although the window opens on the bottom left corner in minimised view. :-/ |
Add retina display support for OSX.
More information about the retina display can be found on Apple Developer websites.
This will close this issue.