Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cohort 7 Notebook with Data Loading from Warehouse and Code Cleanup #358

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

hanlunBCRegistries
Copy link
Collaborator

Issue: #288

Description:

This PR introduces several updates to the Cohort 7 notebook, focusing on loading data from the warehouse, improving code structure, and cleaning up unnecessary outputs.

Key Changes:

  • Data Loading:

    • Integrated logic to load business data from the Warehouse.
    • Created an updated get_pool() function for better connection pooling, enabling both Business and Warehouse database connections.
  • Code Cleanup:

    • Removed all previous cell outputs for a cleaner notebook state.
    • Deleted obsolete CSV files.
  • Data Processing Enhancements:

    • Updated SQL queries to pull business data from COLIN and process it for AR reminders.
    • Improved formatting of columns and handled data types for easier insertion into the Business AR database.
  • General Improvements:

    • Streamlined environment variable loading for better clarity and reusability.
    • Fixed column name mappings and data conversions for smoother execution.

@hanlunBCRegistries hanlunBCRegistries merged commit 752a6cb into main Sep 19, 2024
5 checks passed
@hanlunBCRegistries hanlunBCRegistries changed the title Hanlun notebook updated Update Cohort 7 Notebook with Data Loading from Warehouse and Code Cleanup Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants