2294 bciers apps e2e #2296
Open
2294 bciers apps e2e #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellmueller
force-pushed
the
2294-bciers-apps-e2e
branch
3 times, most recently
from
8738dc8
to
68256c1
Compare
marcellmueller
commented
Sep 27, 2024
| @@ -6,3 +6,5 @@ export { default as Bread } from "./navigation/Bread"; | |||
| export * from "./theme/ThemeRegistry"; | |||
| export * from "./theme/EmotionCache"; | |||
| export * from "./theme/theme"; | |||
|
|
|||
| console.log("Trigger NX Affected"); | |||
There was a problem hiding this comment.
Note: need to remove this after this has been reviewed :)
marcellmueller
commented
Sep 27, 2024
Comment on lines
-80
to
84
| nx_project: coam | ||
| nx_app_port: 7000 | ||
| image_url: "ghcr.io/bcgov/cas-coam-frontend" | ||
| is_nx_affected: ${{contains(needs.check-nx-affected.outputs.NX_AFFECTED_E2E, 'coam') || github.ref_name == 'develop' || github.ref_name == 'main' || github.head_ref == 'develop' || github.head_ref == 'main'}} | ||
| nx_app_port: 7000 | ||
| nx_project: coam | ||
| secrets: inherit |
There was a problem hiding this comment.
A lot of these changes are me just neurotically putting things in alphabetical order 😅
marcellmueller
force-pushed
the
2294-bciers-apps-e2e
branch
2 times, most recently
from
51306ab
to
b45389c
Compare
marcellmueller
force-pushed
the
2294-bciers-apps-e2e
branch
from
b45389c
to
22f169a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2294
docker-compose-bciers-apps.yamlfiledashboard-e2eGitHub workflowrun-nx-appaction andtest-nx-project-e2eworkflow to accept another docker-compose fileCAS_ADMINuser so the previous fix didn't work.Local testing
Making sure this is working in CI
To verify it's working in CI check out the
cas-dashboardHappo diffs at the bottom of this PR.Important:A console.log has been added to trigger nx affected for all apps. It was added for testing/reviewing purposes so we can make sure all e2e jobs are still functioning correctly :)