Refactored duplicate hash related code in tx.js and abstractblock.js #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actblock.js. Created a new class 'hasHashBehavior' that they inherit from.
haxwell
changed the title
|
@pinheadmz Can I get a review on this? If not from you, another knowledgeable person.. Thanks :) |
|
@masterchief164 Thanks for the offer to do a review.. I know your time is limited, so please do this one first! Thank you... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRYed up some duplicate code. Moved common hash related code from tx.js and abstractblock.js to a new parent class defined in hasHashBehavior.js.