Add wallet HD paths to JSON received from create TX #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes a new class WalletCoinView and a helper class Paths. WalletCoinView inherits from CoinView and adds the ability to store HD paths on coin viewpoint objects.
This commit exposes a new 'network' argument to `toPath`. Passing the network type will generate a full HD path instead of the current, abbreviated path.
also clean up backports form hsd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of handshake-org/hsd#145 and handshake-org/hsd#802 from hsd. It adds wallet paths in the JSON from creating transactions so external signers can derive the right private keys, and also inform the user about the total balance from a tx.