Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for options type while creating network #1136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yatharthagoenka
Copy link

@yatharthagoenka yatharthagoenka commented Jan 30, 2023

Fixes #1126
The solution proposed check whether 'options' is an object instance, and if so whether it has an attribute 'type' of type string using the assert function. In case this doesn't check out, the function would simply return a message invalidating the object, and avoid the issue altogether.
If 'options' isn't an object, the function is carried out as done already.

@@ -132,6 +132,9 @@ class Network {
if (typeof options === 'string')
options = networks[options];

if (options instanceof Object)
assert(!options.type, 'Unknown network.');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have added a ! by mistake. Moreover we should use assert(options.type && options.type in networks, 'Unknown network.') to check if the options object has a type and if it does then it is a valid type.

Copy link

@Harsh06-afk Harsh06-afk Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, is anyone working on this PR or not? If not, can I work on this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure go ahead 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should Network.create() take a specific type as its parameter?
3 participants