Added check for options type while creating network #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yatharthagoenka
force-pushed
the
options-type-check
branch
from
efff38f
to
38f879b
Compare
yatharthagoenka
force-pushed
the
options-type-check
branch
from
38f879b
to
262685f
Compare
masterchief164
suggested changes
May 11, 2023
| @@ -132,6 +132,9 @@ class Network { | |||
| if (typeof options === 'string') | |||
| options = networks[options]; | |||
|
|
|||
| if (options instanceof Object) | |||
| assert(!options.type, 'Unknown network.'); | |||
There was a problem hiding this comment.
I think you have added a ! by mistake. Moreover we should use assert(options.type && options.type in networks, 'Unknown network.') to check if the options object has a type and if it does then it is a valid type.
There was a problem hiding this comment.
Hey, is anyone working on this PR or not? If not, can I work on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1126
The solution proposed check whether 'options' is an object instance, and if so whether it has an attribute 'type' of type string using the assert function. In case this doesn't check out, the function would simply return a message invalidating the object, and avoid the issue altogether.
If 'options' isn't an object, the function is carried out as done already.