Add support for native libraries #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
Pong! Sorry for letting this languish, I will try to spend some time on it in the next few days. |
|
ping again :) |
benley
reviewed
Dec 22, 2017
pex/wrapper/pex_wrapper.py
Outdated
| @@ -109,6 +110,10 @@ def main(): | |||
| raise RuntimeError("Failed to add %s: %s" % (egg, err)) | |||
|
|
|||
| # TODO(mikekap): Do something about manifest['nativeLibraries']. | |||
There was a problem hiding this comment.
Remove the TODO comment please, since you have now Done Something about nativeLibraries :-)
pex/pex_rules.bzl
Outdated
| @@ -156,10 +156,15 @@ def _gen_manifest(py, runfiles): | |||
| ), | |||
| ) | |||
|
|
|||
| # All .so files that end with .so, .so.#, .so.#.#, etc. | |||
There was a problem hiding this comment.
Will these ever be .dylib (macos) or .dll (windows), or do python libs always end up named .so regardless of platform?
There was a problem hiding this comment.
Done, though since we don't have platform information (yet? see bazelbuild/bazel#2045), I had to add all possibilities. This means that if you, for instance, create a PEX on linux that's going to ship a pyd to a Windows machine, that we're going to extract the pyd early for no reason. Oops!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates a
native_libs.txtfile that includes all the.sofiles that are in the pex file, so they get extracted together (eager extraction).