pex_binary: Support PEXes with no entry points (interpreters) #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using pex without any entry points, it creates a PEX that is an interpreter that uses the bundled environment. This can be useful to distribute in order to execute other scripts. interpreter_only_test.py: Verify that the PEX starts an interpreter. Fixes the following Skylark exceptions in pex_binary: File ".../bazel_rules_pex/examples/BUILD", line 24 pex_binary(name = 'interpreter_only') File ".../bazel_rules_pex/pex/pex_rules.bzl", line 177, in _pex_binary_impl pex_file_types.filter(ctx.files.srcs)[0] index out of range (index is 0, but sequence has 0 elements) File ".../bazel_rules_pex/examples/BUILD", line 24 pex_binary(name = 'interpreter_only') File ".../bazel_rules_pex/pex/pex_rules.bzl", line 225, in _pex_binary_impl main_pkg name 'main_pkg' is not defined
evanj
force-pushed
the
pex-interpreters
branch
from
901dae9
to
16c002e
Compare
|
This will unfortunately conflict with #61 . If you merge one of them, I'll happily fix the merge/rebase conflicts on the other for you. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using pex without any entry points, it creates a PEX that is an
interpreter that uses the bundled environment. This can be useful to
distribute in order to execute other scripts.
interpreter_only_test.py: Verify that the PEX starts an interpreter.
Fixes the following Skylark exceptions in pex_binary: