Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/46 - Fix magic methods not working as intended #47

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Commits on May 6, 2020

  1. Introduce set_defaults() method.

    This commit introduces a private data() array, and a public method for classes that extend Base to call to setup the defaults.
    
    This is necessary to make sure that all default class variables make their way into the data array so that magic methods can access them like they can any other variable.
    JJJ committed May 6, 2020
    Configuration menu
    Copy the full SHA
    fb2c498 View commit details
    Browse the repository at this point in the history
  2. Use set_defaults() in all other classes.

    This commit is necessary to make sure that all object properties are correctly setup in the private data array.
    JJJ committed May 6, 2020
    Configuration menu
    Copy the full SHA
    ad0ebf4 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Configuration menu
    Copy the full SHA
    1f20ae8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30c9a5a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c33f90f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6e93309 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2020

  1. Configuration menu
    Copy the full SHA
    fdcc5be View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Various fixes to make $data storage work correctly

    * Change from array to object
    * Introduce unset_vars() to parlay off of set_vars()
    * Introduce validate_key() to reduce some code duplication in magic methods
    * Switch from is_callable() to method_exists() so that it works as intended with __call()
    * Make sure magic un/set methods operate on the correct variables
    * Avoid setting object array keys directly, triggering byref debug notices
    * Some general code & docs improvements to related methods
    * Add 'join' to query & request clauses
    JJJ committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    7238931 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Configuration menu
    Copy the full SHA
    89d4e20 View commit details
    Browse the repository at this point in the history