-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/46 - Fix magic methods not working as intended #47
Open
JJJ
wants to merge
9
commits into
master
Choose a base branch
from
issue/46
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on May 6, 2020
-
Introduce set_defaults() method.
This commit introduces a private data() array, and a public method for classes that extend Base to call to setup the defaults. This is necessary to make sure that all default class variables make their way into the data array so that magic methods can access them like they can any other variable.
Configuration menu - View commit details
-
Copy full SHA for fb2c498 - Browse repository at this point
Copy the full SHA fb2c498View commit details -
Use set_defaults() in all other classes.
This commit is necessary to make sure that all object properties are correctly setup in the private data array.
Configuration menu - View commit details
-
Copy full SHA for ad0ebf4 - Browse repository at this point
Copy the full SHA ad0ebf4View commit details
Commits on Aug 26, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1f20ae8 - Browse repository at this point
Copy the full SHA 1f20ae8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30c9a5a - Browse repository at this point
Copy the full SHA 30c9a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c33f90f - Browse repository at this point
Copy the full SHA c33f90fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e93309 - Browse repository at this point
Copy the full SHA 6e93309View commit details
Commits on Sep 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fdcc5be - Browse repository at this point
Copy the full SHA fdcc5beView commit details
Commits on Sep 22, 2020
-
Various fixes to make $data storage work correctly
* Change from array to object * Introduce unset_vars() to parlay off of set_vars() * Introduce validate_key() to reduce some code duplication in magic methods * Switch from is_callable() to method_exists() so that it works as intended with __call() * Make sure magic un/set methods operate on the correct variables * Avoid setting object array keys directly, triggering byref debug notices * Some general code & docs improvements to related methods * Add 'join' to query & request clauses
Configuration menu - View commit details
-
Copy full SHA for 7238931 - Browse repository at this point
Copy the full SHA 7238931View commit details
Commits on Sep 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 89d4e20 - Browse repository at this point
Copy the full SHA 89d4e20View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.