Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi sélection des énergies dans les filtres #901

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

Copy link
Member

@totakoko totakoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques commentaires / questions, 1 label à changer et le comportement un peu foireux chez moi, sinon c'est good. 😉
fcu-combobox-chelou

src/components/NetworksList/NetworksList.tsx Outdated Show resolved Hide resolved
src/components/form/dsfr/SelectCheckboxes.tsx Show resolved Hide resolved
'use client';

// Based on https://ui.shadcn.com/docs/components/popover
// WIth the added functionnality of the width of the content to be at least the width of the trigger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On utilise @radix-ui popover mais inspiré de shadcdn ? 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En fait shadcn est une bibilothèque de composant à copier coller dans ton code

Shadcn est basé sur

  • tailwind
  • radix-ui

J'ai transformé tailwind en styled-components
radix-ui est une librarie headless de composants sans style qui implémentent les comportements les plus courant

src/components/ui/Popover.tsx Show resolved Hide resolved
src/components/ui/Popover.tsx Outdated Show resolved Hide resolved
src/hooks/useDimensions.tsx Outdated Show resolved Hide resolved
src/components/Map/components/ReseauxDeChaleurFilters.tsx Outdated Show resolved Hide resolved
@totakoko
Copy link
Member

totakoko commented Oct 17, 2024

@martinratinaud J'ai retesté, mais j'ai toujours le même problème où il faut double cliquer pour ouvrir le popover... 😬 Je suis sous chrome

Sur firefox ça fonctionne, même s'il y a un petit artefact graphique... où on voit le menu sans contenu

Copy link
Member

@totakoko totakoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est bon 👍

@martinratinaud martinratinaud merged commit ba72c6e into dev Oct 17, 2024
5 checks passed
@martinratinaud martinratinaud deleted the multi_energies_filters branch October 17, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants