Maj couche batiments raccordés chaleur + ajout couche batiments raccordés froid #903
+187
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinratinaud
approved these changes
Oct 17, 2024
| @@ -107,6 +110,16 @@ export const tilesInfo: Record<DatabaseSourceId, TileInfo> = { | |||
| properties: ['fid', 'ADRESSE', 'CONSO', 'PDL', 'ID'], | |||
| sourceLayer: 'raccordements', | |||
| }, | |||
| batimentsRaccordesReseauxChaleurFroid: { | |||
There was a problem hiding this comment.
Ajouter un lien vers la doc dans Notion
| @@ -1,3 +1,4 @@ | |||
| // FIXME à supprimer | |||
There was a problem hiding this comment.
// FIXME à supprimer après le déploiement en prod de batimentsRaccordesReseauxChaleurFroid
| properties: [], // useless | ||
| sourceLayer: '', // useless | ||
| id: '', // useless | ||
| extraWhere: (query) => query, // useless |
There was a problem hiding this comment.
si useless, pkoi le garder?
There was a problem hiding this comment.
A cause du typage de la structure legacy 🙃
| @@ -233,11 +233,17 @@ const trackingEvents = { | |||
| 'Carto|Bâtiments au fioul collectif|Désactive': { | |||
| matomo: ['Carto', 'Bâtiments au fioul collectif', 'Désactive'], | |||
| }, | |||
| 'Carto|Bâtiments raccordés|Active': { | |||
| matomo: ['Carto', 'Bâtiments raccordés', 'Active'], | |||
| 'Carto|Bâtiments raccordés réseau chaleur|Active': { | |||
There was a problem hiding this comment.
Faut il prevenir l'équipe que l'event va changer?
There was a problem hiding this comment.
🤷 Je ne sais pas comment on fait pour versionner / suivre ça. Je vais poser la question à Florence pour voir ce qu'elle préfère.
There was a problem hiding this comment.
C'est bon pour Florence.
| }, | ||
| }, | ||
| ], | ||
| }, | ||
| // { |
There was a problem hiding this comment.
Non pas du tout merci !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construction des données